InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Published 20 hours ago • verified publisher icon InfiniTimeOrg

Show alarm controller state in status icons

Open jmlich opened this issue 2 years ago • 8 comments

I would like to know if the alarm is active on Watch Face Digital screen.

I made an prototype with InfiniSim and it looks that it works as expected:

InfiniSim_2023-10-08_113731 infinisim

However, I have only sealed version of PineTime and this is my first attempt to make something for embedded device. I will be happy if someone can check if this actually works on real device. I am looking forward for your feedback.

jmlich avatar Oct 08 '23 09:10 jmlich

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

github-actions[bot] avatar Oct 08 '23 10:10 github-actions[bot]

I have also tested the feature on hardware.

jmlich avatar Oct 21 '23 13:10 jmlich

I like this, but I think the icon has a little too much filled space and the simple circle isn’t as defined as a more standard alarm icon: image Of course these might not work with a resolution that small, but I’m sure something similar could…

LinuxinaBit avatar Nov 09 '23 14:11 LinuxinaBit

I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.

I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.

jmlich avatar Nov 09 '23 15:11 jmlich

Ah, I forgot it was already the icon for the alarm app. Sorry about that.

On November 9, 2023 9:30:26 AM CST, Jozef Mlich @.***> wrote:

I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.

I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.

-- Reply to this email directly or view it on GitHub: https://github.com/InfiniTimeOrg/InfiniTime/pull/1884#issuecomment-1804051536 You are receiving this because you commented.

Message ID: @.***>

LinuxinaBit avatar Nov 09 '23 15:11 LinuxinaBit

This should be rebased against main and updated to reflect the new icon from https://github.com/InfiniTimeOrg/InfiniTime/pull/1996

vkareh avatar Feb 12 '24 21:02 vkareh

@jmlich I'd like to give this change a try, would you mind rebasing this changeset against the current state of main?

rnwgnr avatar Aug 15 '24 18:08 rnwgnr