InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Published 20 hours ago • verified publisher icon InfiniTimeOrg

Adds scroll bar to music app

Open SteveAmor opened this issue 1 year ago • 7 comments

Fixes #1391

SteveAmor avatar Oct 04 '23 19:10 SteveAmor

Build size and comparison to main:

Section Size Difference
text 376848B 64B
data 940B 0B
bss 63420B 0B

github-actions[bot] avatar Oct 04 '23 19:10 github-actions[bot]

InfiniSim_2023-10-04_202308

SteveAmor avatar Oct 04 '23 19:10 SteveAmor

I imagine it could look a little better with a little margin around the buttons. What do you think?

minacode avatar Oct 04 '23 19:10 minacode

The page indicator is 2px wide. However, if I move the buttons 3px, it conveniently has a 3px space between the play/pause button too, making it nice and symmetrical. What do people think?

InfiniSim_2023-10-05_080028

For comparison, here are the buttons moved 2px

2px

SteveAmor avatar Oct 05 '23 07:10 SteveAmor

I like the first image where the bar is not touching the button.

minacode avatar Oct 05 '23 07:10 minacode

PR updated to move the buttons 3px.

SteveAmor avatar Oct 05 '23 08:10 SteveAmor

I experimented with hiding or deleting the page indicator object when you switch pages. According to the simulator, hiding the object used more lvgl memory than deleting and creating. So I went with deleting. I guess it used more memory as you actually had more objects at any one time, with one of them hidden.

SteveAmor avatar Oct 05 '23 15:10 SteveAmor