InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

initial i18n support for notification

Open Boteium opened this issue 1 year ago • 7 comments

I decide to write a PoC for notification i18n support https://github.com/InfiniTimeOrg/InfiniTime/issues/1473 This requires https://github.com/InfiniTimeOrg/lvgl/pull/3

This will enable people to start working on i18n support for their own languages. The design uses external flash so that people can flash the language pack of their choice. To reduce memory footprint, only the very basic glyph should be added, which means the example provided here (latin.json) should further be split to Spanish, French, Sweden ... etc

We should also limit the file size of this font to prevent people from building a huge font that will crash and brick their watches. So, It is not possible to add support for Chinese or Japanese using this method.

InfiniSim_2023-06-18_180701

.

Boteium avatar Jun 18 '23 10:06 Boteium

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

github-actions[bot] avatar Jun 18 '23 10:06 github-actions[bot]

Can we also have this on the music screen? A lot of my playlists are Japanese music.

everypizza1 avatar Aug 12 '23 14:08 everypizza1

Can we also have this on the music screen? A lot of my playlists are Japanese music.

Well, It depends,

Yes, we can make this method system wide. But no, Japanese contains too many glyphs, which won't fit in the memory.

However, limited support is possible. (e.g. only includes hiragana and katakana)

Boteium avatar Aug 12 '23 14:08 Boteium

Can we at least romanize it?

On Sat, Aug 12, 2023, 9:51 AM SuIông N. @.***> wrote:

Can we also have this on the music screen? A lot of my playlists are Japanese music.

Well, It depends,

Yes, we can make this method system wide. But no, Japanese contains too many glyphs, which won't fit in the memory.

However, limited support is possible. (e.g. only includes hiragana and katakana)

— Reply to this email directly, view it on GitHub https://github.com/InfiniTimeOrg/InfiniTime/pull/1773#issuecomment-1675948178, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATXE5QKICJME4NNDNARRAVTXU6KA7ANCNFSM6AAAAAAZKZKA3Y . You are receiving this because you commented.Message ID: @.***>

everypizza1 avatar Aug 12 '23 15:08 everypizza1

We can't romanize it on-device, that would require a lot of logic we don't want to implement, but the companion app would be able to.

FintasticMan avatar Aug 12 '23 17:08 FintasticMan

I think hiragana and katakana support would be better than nothing

ThatOneCalculator avatar Dec 18 '23 17:12 ThatOneCalculator

I've been testing this for a while, this looks like a good step towards proper i18n support. I've been using the latin pack, without it, notifications in french are barely readable. Thanks for that PR, hopefully this can be merge at some point :)

minimaxwell avatar Mar 26 '24 14:03 minimaxwell