InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Remove the vibration while charging

Open minacode opened this issue 2 years ago • 8 comments

This fixes #724 where the vibration interupts the physical connection with the charger and therefore triggers a new charging event and vibration, ending in a cycle of vibrations while charging.

minacode avatar Jun 05 '23 08:06 minacode

Build size and comparison to main:

Section Size Difference
text 369768B -16B
data 940B 0B
bss 63516B 0B

github-actions[bot] avatar Jun 05 '23 08:06 github-actions[bot]

I like this, I have experienced this problem many times. But I would still like some way to be sure the watch is charging other than the tiny icon that is hard to see. Maybe the battery settings page opens when charging?

Itai-Nelken avatar Jun 20 '23 17:06 Itai-Nelken

I like this, I have experienced this problem many times.

Nice :) It seems to be a common issue.

But I would still like some way to be sure the watch is charging other than the tiny icon that is hard to see. Maybe the battery settings page opens when charging?

I think that would belong to another PR. This one is only about removing the bug.

minacode avatar Jun 20 '23 23:06 minacode

That's not a problem I have had on the sealed watch, but the vibration is very loud.

88572 avatar Jul 20 '23 22:07 88572

Just FYI there is also #1876

mark9064 avatar Oct 30 '23 19:10 mark9064

Which I like even more! 😄 I hope your gets merged. We can close this one if it did.

minacode avatar Oct 31 '23 00:10 minacode

I do like the tactility though, what about only doing the vibration if there hasn’t been a charging event in the last ~1 minute?

LinuxinaBit avatar Nov 09 '23 16:11 LinuxinaBit

I will keep this PR as simple as possible and just remove the one line.

minacode avatar Jan 14 '24 01:01 minacode