InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Edit all occurences of "watch face" to "watchface"

Open mashuptwice opened this issue 2 years ago • 2 comments

In some of the docs, settings and CMakeList, "watchface" was written as two words:

╰─$ grep -ri "watch face"
doc/gettingStarted/gettingStarted-1.0.md:### Digital watch face
doc/gettingStarted/gettingStarted-1.0.md:![Digital watch face](ui/watchface.jpg)
doc/gettingStarted/gettingStarted-1.0.md:This is what the default digital watch face looks like. You can change watch faces in the settings.
doc/gettingStarted/gettingStarted-1.0.md:- You can hold the button for a short time to return to the watch face. (version >1.7.0)
src/CMakeLists.txt:        ## Watch faces
src/displayapp/screens/settings/Settings.h:          {Symbols::home, "Watch face", Apps::SettingWatchFace},
src/displayapp/screens/settings/SettingWatchFace.cpp:  lv_label_set_text_static(title, "Watch face");

While most of the time it was referenced as single word:

╰─$ grep -r "Watchface\|watchface"
doc/MemoryAnalysis.md:Using this technique, I was able to trace all malloc calls at boot (boot -> digital watchface):
doc/InfiniTimeVision.md:- Personalization is achieved through custom watchfaces.
doc/InfiniTimeVision.md:- Capability to sideload apps and watchfaces
doc/gettingStarted/updating-software.md:You can check the InfiniTime version by first swiping right on the watchface to open quick settings, tapping the cogwheel to open settings, swipe up until you find an entry named "About" and tap on it.
doc/gettingStarted/updating-software.md:- From the watchface, swipe **right** to display the *quick settings menu*
doc/gettingStarted/gettingStarted-1.0.md:By default, InfiniTime starts on the digital watchface. It'll probably display the epoch time (1 Jan 1970, 00:00).
doc/gettingStarted/gettingStarted-1.0.md:![Digital watch face](ui/watchface.jpg)
src/displayapp/screens/WatchFacePineTimeStyle.cpp: * PineTimeStyle watchface for Infinitime created by Kieran Cawthray
src/components/ble/weather/WeatherData.h:       * As direction can fluctuate wildly and some watchfaces might wish to display it nicely,
src/components/ble/weather/WeatherData.h:       * Location info can be for some kind of map watchface
src/components/ble/weather/WeatherData.h:       * this allows watchface or watchapp makers to generate accurate alerts and graphics

I've changed all occurences to a single word, in accordance with most of the docs and code.

mashuptwice avatar Aug 28 '22 11:08 mashuptwice

I personally think that watch face as separate words is better, and I believe that is mirrored by the code using a capital F in WatchFace.

FintasticMan avatar Aug 28 '22 11:08 FintasticMan

@FintasticMan The dictionary suggests the same.

I've also added #1304 as opposite of this PR.

ghost avatar Aug 28 '22 12:08 ghost

the opposite PR https://github.com/InfiniTimeOrg/InfiniTime/pull/1304 got merged, closing

NeroBurner avatar Oct 11 '22 19:10 NeroBurner