InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Improve status icon visibility

Open Riksu9000 opened this issue 2 years ago • 13 comments

Making the icons white Improves the visibility, but also makes them more subdued instead of attention grabbing. I was planning on making this change regardless of #1263.

Relates to #958. One of the necessary changes for #1263.

InfiniSim_2022-08-03_092844 InfiniSim_2022-08-03_092845 InfiniSim_2022-08-03_092847 InfiniSim_2022-08-03_092851

Riksu9000 avatar Aug 03 '22 09:08 Riksu9000

in case of #1263 , rather to white them , it would be give them a colors that is visible in related to their "color blindness" so it's not "necessary"

each product that implement color blindness , change color icon . with a setting , but not remove color

lman0 avatar Aug 04 '22 12:08 lman0

if you make the whole infinitme coherent with whitening icon , then infinitme will become a "black/white" gui with every screen in black and white an it don't think it should be a default (in my case , it may make me no longer find pinetime interesting since the screen would be forbidden to hold color)

lman0 avatar Aug 04 '22 12:08 lman0

@lman0 The original description of this PR clearly specify that these changes are suggested regardless of the color blindness functionality. It just mentions that those changes could also be part of a potential color blindness feature. To avoid confusion, please avoid mixing topics and continue the color blindness discussion in #1263.

JF002 avatar Aug 04 '22 19:08 JF002

@lman0 The original description of this PR clearly specify that these changes are suggested regardless of the color blindness functionality. It just mentions that those changes could also be part of a potential color blindness feature. To avoid confusion, please avoid mixing topics and continue the color blindness discussion in #1263.

@JF002 first he do , say that but then he say it necessary for the request ! it's not necessary for the request ! in fact the request don't even implies to make icon in white!

if he had sayed like you , that "those changes could also be part of a potential color blindness feature." i don't thinks @lman0 would not even commented , since it could be the case

trman avatar Aug 04 '22 19:08 trman

@trman don't respond in place please , i think it already complicated enough!

@JF002 the reason is llike @trman have said , but i would liked to said that myself ... :(

lman0 avatar Aug 04 '22 20:08 lman0

@lman0 sorry , i did take to heart because , i think your comment on white sounded like mine and was like what i thinked on this part...

again sorry( i have edited mi comment)

trman avatar Aug 04 '22 21:08 trman

I quite like the blue bluetooth icon. When I glance at my watch the blue of the icon immediately tells me that bluetooth is connected. Removing the color would remove this (felt) faster info.

Not a strong vote against or for this PR, just a weak preference for color from me

NeroBurner avatar Aug 07 '22 18:08 NeroBurner

Please consider that white icons work well anywhere and in my opinion they look better because they are less distracting on these screens. On the watchfaces I didn't consider it an issue, but I also changed them to white for consistency. This happened to fix one of the problems with #1263, but was not planned, because I thought of these changes as generally positive for everyone.

Rest assured I'm not looking to make InfiniTime monochrome, but use color in moderation.

InfiniSim_2022-08-08_130123 InfiniSim_2022-08-08_130125

Riksu9000 avatar Aug 08 '22 13:08 Riksu9000

removed

trman avatar Aug 08 '22 17:08 trman

to thinks that @lman0 #1263 was about changing color for blind color so they can see color again

i :+1: for the irony of showing us , one last, time the color you will remove from infinitime (maybe it's a mistake when choosing the picture i wonder @Riksu9000 ?

do you will remove the red and blue from from the analog (for consistency)?

trman avatar Aug 08 '22 17:08 trman

beware ! since there is about the whole color spectrum blindness, if you plan to remove first red blue , then green yellow then ... obvious at the end infinitme will be obviously black and white

so don't make the mistake try of doing the best and make it worse!

as long it's , only this it's shouldn't much a problem

trman avatar Aug 08 '22 17:08 trman

@trman attacking people who invest their free time to make something better for the whole community is just plain wrong. This hurts the project by poisoning the community interaction. Please refrain doing so in the future and think about the other person who has to read a hurtful comment.

@Riksu9000 has good intentions and good arguments (making something look better/more consistent and as a side effect make the interface easier to read for more people).

Personal attacks on the other hand show the lack of good arguments against the changes proposed in this PR. The person using a personal attack in an argument (in my eyes) has lost the discussion per default.

I personally like the blue icon in the interface, but neither my Android phone, nor my KDE Plasma deskop has a blue bluetooth icon, and they both have a good and consistent look (and designers, which I trust understand more about consistent design than I do).

NeroBurner avatar Aug 08 '22 19:08 NeroBurner

Since the beginning, working on InfiniTime is fun, interesting and rewarding. I am really grateful to all those who contribute to this project, who propose ideas and features, who report bugs, who discuss technical or functional issues,...

I'm also very thankful to the contributors who accepted to join the @InfiniTimeOrg/core-developers team. I asked them to join the project because we share the same vision about the project, because they did awesome contributions and because I trust them to make the right decisions for the good of InfiniTime.

Together, I feel like we are accomplishing great things while having fun and learning new things.

... And I can't let anyone ruin the fun! I'm not proud of this, but I've just open the Github doc regarding the moderation of comments, and I decided to block this troublesome user for some time to let them take a step back and reflect about their contribution to this project. I hope they'll come back with a fresh mind and a more constructive attitude.

To everyone else : I'm really sorry about this! Let's try to get over it and resume our exciting discussions about InfiniTime!

JF002 avatar Aug 09 '22 20:08 JF002

I was out in the bright sun a lot in the last days and noticed that the blue of the Bluetooth icon has too less contrast against the black background, even on highest brightness.

minacode avatar Aug 12 '22 07:08 minacode