InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

Add sleep mode

Open Riksu9000 opened this issue 2 years ago • 16 comments

A sleep mode is needed so the watch can be worn during the night without causing the menus to activate.

Sleep mode disables notifications, touch wakeup, motion wakeup and chimes.

InfiniSim_2022-08-02_105252

Fixes #689

Riksu9000 avatar Aug 02 '22 10:08 Riksu9000

Nice work! I think it should also disable chimes so that if you enable sleep mode you don't get woken up every (half) hour.

FintasticMan avatar Aug 02 '22 14:08 FintasticMan

i want to know, @Riksu9000 , what is the difference with #961 ? if there is next to none , why not merging the #961 first ? (you could resolve the residuel conflict)

trman avatar Aug 02 '22 20:08 trman

here is things i have seen , with people around me and on other open source projects:

behavior : someone will close or draft other people pull only to make shine his copy

i've seen projects crumble from inside with this kind of behavior , because people felt dumb to try to add functionality only to see their pull forever left to no be merged or worst closed and their idea copied by the guy that closed their pull with a pull with his name on it , that he say that it resolve everything

at the end , people did'nt try anymore to help the project and the project became to be a one man project with n one wanting to help

sometime some people create a sister project that forbid this kind of behavor (i thinks it was the case for gitea)

trman avatar Aug 02 '22 20:08 trman

@trman I created #961, it is a pull request with a very different goal and use-case. This pull request disables things that could be a distraction for going to sleep, while my pull request is a fix (debatable) for the issue of the touch panel recognising touches if you didn't touch the screen.

There aren't many solutions to the issue of distractions when you're sleeping, so this pull request would be pretty easy to merge. There are many ways to solve the issue of ghost inputs, one of which is mine. The way to figure out which works best is by trying them, and so far there haven't been any other implementations of a fix to compare against.

I am planning on updating my pull request and trying to fix the issues it has, but I don't think these pull requests are at all related.

Please don't be overly cynical when you don't understand the situation.

FintasticMan avatar Aug 02 '22 21:08 FintasticMan

when i see two pull that remove touch with one in draft and the other nearly merged it's normal to me me that it is explained why the previous is not merged first.

for the cynical , i've seen @Riksu9000 closing pulls with no reason except he seem don't like the pulls purpose... even if it's updated this time it felt a little too big

I am planning on updating my pull request and trying to fix the issues it has, but I don't think these pull requests are at all related.

the #961 would no longer serve any purpose , @FintasticMan since it only need to click on the "sleep" icon in order to disable/make sleep the touch screen it fact , i would not be surprised at all if @Riksu9000 close the pull , once this one is merged because of this ability/side effect

trman avatar Aug 02 '22 21:08 trman

hi @Riksu9000 , is clicking on the button is enough to restore the touch screen?

lman0 avatar Aug 02 '22 21:08 lman0

the https://github.com/InfiniTimeOrg/InfiniTime/pull/961 would no longer serve any purpose , @FintasticMan since it only need to click on the "sleep" icon in order to disable/make sleep the touch screen

This pull request doesn't disable touch, it only disables touch wakeup.

FintasticMan avatar Aug 02 '22 21:08 FintasticMan

the explanation was lacking @FintasticMan , so i understood it was "touch" aka touch screen and "motion wake up" disablement

trman avatar Aug 02 '22 21:08 trman

right now , the only thing that wake up the screen in my case is the touch screen because i don't use the wake up by wrist or screen . and i disable the notification before sleeping. is this pull will stop the screen wake up because of touch @Riksu9000 ? or it' a shortcut for my actions?

what said @trman and @FintasticMan make me doubt...

lman0 avatar Aug 02 '22 22:08 lman0

@Riksu9000 please include chimes in this. It makes sense and would resolve #1083 I opened some time ago and never found the time to work on.

Also red light would be more reasonable for sleeping than blue light, so maybe swap the red and blue background. Sleep mode also opens up more ideas like override the brightness to be always low, but keep the setting for the day.

minacode avatar Aug 02 '22 23:08 minacode

I've now updated the description to be more clear about what this PR does and also disabled Chimes. Thanks @FintasticMan for clearing up the confusion.

Let's stay on topic from this point on.

Riksu9000 avatar Aug 03 '22 05:08 Riksu9000

This would be a good point to resolve #183 and parts of #895 with an always-on mode, similar to caffeine on LineageOs/Android.

infinitime-always-on_2nd_logo

ghost avatar Aug 04 '22 01:08 ghost

I like this idea, not sure if it would warrant a separate issue or not but I would appreciate a Do Not Disturb functionality that is configurable in the quick settings, which will automatically turn on and off at the times/schedule you specify like on phones.

calhix avatar Aug 04 '22 18:08 calhix

Great work, I was about to make the same changes myself, beat me to it!

Tiggilyboo avatar Aug 05 '22 11:08 Tiggilyboo

Used the feature last night works flawlessly! Thank you so much for following through greatly improves the usability of the watch for me!

jakethelizard99 avatar Aug 07 '22 20:08 jakethelizard99

more than sleeping , it' s more a 'silent mode' to me . a true or complete sleep mode , for me , would add as well :

  • screen dimmed (full light not good when sleeping)
  • color filtered (like on android/pc/mac , the 'blue' color filter , that activate/is activated at night making white turn to amber )

and optionally slow down battery usage as well with performance reduced but clock and alarm functional.

lman0 avatar Aug 09 '22 11:08 lman0

Would it be possible to go in/out of this mode when sleep tracking via Sleep as Android?

wmertens avatar Oct 16 '22 09:10 wmertens