InfiniTime icon indicating copy to clipboard operation
InfiniTime copied to clipboard

DigitalWatchFace & WatchFacePineTimeStyle: show clock icon when alarm is active

Open faxe1008 opened this issue 3 years ago • 7 comments

When using the device I am often uncertain if I did infact set the alarm. This patch adds display of the clock icon for the DigitalWatchFace and WatchFacePineTimeStyle.

I decided not to add it to the other onces since:

  • Terminal is already quite full and I did not want to clutter it further
  • Analog: It did not fit the style, since the bleIcon is also not shown I assume this is meant to be more minimalistic.

Here are some screenshots: image image image image

faxe1008 avatar May 14 '22 19:05 faxe1008

After showing it on discord the idea came up to change the placement and ordering of icons, now PinetimeStyle watch face looks like this: image image image

This way the battery icon lines up with the battery icon in the menu screen :^)

faxe1008 avatar May 14 '22 21:05 faxe1008

Resolved all remarks :^)

faxe1008 avatar May 16 '22 20:05 faxe1008

The gaps between the icons are inconsistent. This is because even though an icon is hidden, it's aligned 5 pixels left, so effectively it increases the gap. This wasn't a big issue until now, but now it is noticable and I think something should be done about it.

I noticed it too but I thought it was down to inconsistent glyph widths. So I guess when we are setting the icon text to empty for ble we should also set the margin to 0? I atm a complete lvgl novice :^)

faxe1008 avatar May 17 '22 13:05 faxe1008

the nice and bad thing about programming: you can do it in multiple ways! :D

it sounds like a good way to start. Try it out and see if it works :+1:

NeroBurner avatar May 17 '22 17:05 NeroBurner

I think there should be an icon for the timer as well.

ghost avatar May 24 '22 16:05 ghost

With #1242 it's now easier to add new status icons. Will you update this PR?

Riksu9000 avatar Aug 09 '22 19:08 Riksu9000

Yes I am, I tried fiddeling around fixing the issue but it did not work, simply did not have any lvgl experience to know whats going wrong. I will at least update the digital watchface to include the info. As for the PineTimeStyle one - I think if we want to have the logic for what icon to show under which conditions still in one spot, I think that having some "grid" layout of the icons be the best approach. That way for the DigitalWatchFace the icons can be 4 columns, 1 row and for the PineTimeStyle one 2x2?

Will first do the DigitalFace one before I try and get fancy with the other one tho :^)

faxe1008 avatar Aug 09 '22 20:08 faxe1008

Closing in favor of adding this in the StatusIcons widget.

Riksu9000 avatar Feb 01 '23 10:02 Riksu9000