George Gamezardashvili
George Gamezardashvili
@antonio2368, Here build fails on darwin, ppc64le due to the lack of explicit_bzero, and freebsd due to lack of ptsname_r in sysroot. The last one is really strange and can...
> @InfJoker for Darwin and ppc64le we are cross compiling, I suspect we are detecting that system has `explicit_bzero` but it's not available when we try to build it with...
> Another batch of small comments, will test it out a bit locally. > > > > Forgot to say it in the last review, but this is really good....
@antonio2368 I'm very sorry to be so late. Now I'm ready to fully work on pull request.
> We shouldn't use check_function_exists in CMake (and other checks), as we use fixed environments for cross-compiling, so our builds don't depend on the environment, and it does not make...
@antonio2368 Hello, Antonio. Sorry for being so slow. After one rebase I stepped into a problem of aggregations stop working when something besides TCP interface being passed to Session object....
@antonio2368 I can see a very strange error. https://s3.amazonaws.com/clickhouse-test-reports/48902/ad050647bb59240b3e714a694293c41b7e6c4870/integration_tests__asan__analyzer__[1_6]/integration_run_parallel3_0.log. Try to search for `____________________ test_simple_query_with_openssh_client _____________________` keyword. With ssh client we get `0` from `select 1`, with normal client we...
> Interesting problem, based on logs from server nothing strange happened. Does it happen always or is it flaky? Maybe something strange happens on the client side. Release version for...
@nikitamikhaylov if you want to merge this soon, feel free to request my help