indonlu icon indicating copy to clipboard operation
indonlu copied to clipboard
verified publisher icon IndoNLP

Add How to Reproduce the Result in README

Open atnanahidiw opened this issue 5 years ago • 7 comments

Refactor:

  • run_single_task.sh
  • run_all_tasks.sh
  • run_non_pretrained_no_special_token.sh

by:

  • Create scripts/config/model/train.yaml to easily define the model used
  • Make scripts/reproducer.py and Makefile for easy ops

Note: only tested this by printing the command string, sorry 🙏

atnanahidiw avatar Sep 26 '20 20:09 atnanahidiw

@gentaiscool : I think we need to change the load_model and clean up the unused model checkpoints that are used for our experiment. We can instead use Indobenchmark model in HF as the replacement. Can you help to clean that part?

@atnanahidiw, later you can follow the checkpoint argument based on the finalized models that we have. So it will be cleaner and easier to follow.

I will clean the code and add the documentation this week including the CONTRIBUTING page. Let's finish the testing and then, we merge this pull request.

gentaiscool avatar Oct 07 '20 08:10 gentaiscool

@gentaiscool : I think we need to change the load_model and clean up the unused model checkpoints that are used for our experiment. We can instead use Indobenchmark model in HF as the replacement. Can you help to clean that part? @atnanahidiw, later you can follow the checkpoint argument based on the finalized models that we have. So it will be cleaner and easier to follow.

I will clean the code and add the documentation this week including the CONTRIBUTING page. Let's finish the testing and then, we merge this pull request.

I added the CONTRIBUTING page in the master branch.

gentaiscool avatar Oct 09 '20 14:10 gentaiscool

@atnanahidiw we just merged the master branch with a new PR #7. Would you mind to check whether this PR has any conflict?

gentaiscool avatar Oct 10 '20 17:10 gentaiscool

hi @gentaiscool, I just resolved all of the conflicts ya, sorry for the late reply 🙏

atnanahidiw avatar Oct 11 '20 09:10 atnanahidiw

I added the CONTRIBUTING page in the master branch.

and thanks also for the CONTRIBUTING page should we make it more verbose? ^^a

atnanahidiw avatar Oct 11 '20 09:10 atnanahidiw

I added the CONTRIBUTING page in the master branch.

and thanks also for the CONTRIBUTING page should we make it more verbose? ^^a

Yes, we should, probably in a new PR?

gentaiscool avatar Oct 11 '20 14:10 gentaiscool

I added the CONTRIBUTING page in the master branch.

and thanks also for the CONTRIBUTING page should we make it more verbose? ^^a

Yes, we should, probably in a new PR?

Yeah I agree, this one can be a new PR. Thank you 😀

SamuelCahyawijaya avatar Oct 11 '20 14:10 SamuelCahyawijaya