ngxd icon indicating copy to clipboard operation
ngxd copied to clipboard

Add support for Angular 17

Open mxshdev opened this issue 1 year ago • 10 comments

Describe the feature you would like to see added

Add support for Angular 17

Describe the solution you'd like

Update peer dependencies to allow angular 16:

"peerDependencies": {
    "@angular/common": "^15.0.0",
    "@angular/core": "^15.0.0",
    "rxjs": ">=6.0.0"
}

Describe alternatives you have considered

  1. Keep on old angular
  2. Force update anyway and run "npm install --force" every time

mxshdev avatar Nov 10 '23 19:11 mxshdev

Angular 17 has breaking change, that affect change detection (and ngxd):

OnPush components that are created dynamically now only have their host bindings refreshed and ngDoCheck run during change detection if they are dirty. Previously, a bug in the change detection would result in the OnPush configuration of dynamically created components to be ignored when executing host bindings and the ngDoCheck function. This is rarely encountered but can happen if code has a handle on the ComponentRef instance and updates values read in the OnPush component template without then calling either markForCheck or detectChanges on that component's ChangeDetectorRef.

janousek avatar Nov 19 '23 08:11 janousek

any ETA on when Angular 17 will be supported?

We're currently having issues described by @janousek and would love to have an official solution, rather than a hacky workaround :)

proggler23 avatar Jan 08 '24 12:01 proggler23

Regarding the above PR.

For those of you who'd like to get moving before this is merged and published, the main change is here:

https://github.com/Indigosoft/ngxd/pull/63/files#diff-43fa391336ab67ea0f7d5dbfb5aa792982bd96c3e92377fbe6edaa7fa418cde0R65-R69

I had to make a change to some of the test code because Angular now handles OnPush and Default change notification differently. That change is here: https://github.com/Indigosoft/ngxd/pull/63/files#diff-cfe523e683be6cacaebf3ed3129dd8d981995a7e9e3222281bda90f3062aa1b0L10-R23

The other changes are just upgrading to Angular 17

DaveMBush avatar Jan 30 '24 19:01 DaveMBush

Any ETA for the new release?

diogogasparr avatar Feb 13 '24 11:02 diogogasparr

@thekiba

diogogasparr avatar Feb 21 '24 15:02 diogogasparr

Any ETA for the new release? @diogogasparr @DaveMBush @thekiba

sergioorlov avatar Mar 25 '24 14:03 sergioorlov