Guillaume

Results 90 comments of Guillaume
trafficstars

We should find a way to run the test only on Windows with specific extension activated? Not sure how to do this...

On the PeachPie side, should I add a test in the COM constructor (and in the function) where I test that we are on Windows and throw an `NotSupportedException` if...

Noted @jakubmisek However, I'm not sure I'll be able to push this implementation further in the short term. Would it be acceptable to merge it "as is"? Some stuff are...

> > > I guess tests :) and also before the release, we are generating the compatibility matrix on https://docs.peachpie.io/compatibility-status/ which you can generate for yourself at https://github.com/peachpiecompiler/peachpie-docs/tree/master/tools (it creates...

@jakubmisek I was missing the lib from the local Nuget packages! Updating the script fixes this issue. However, now I have the following error: ``` Unhandled exception. System.NotImplementedException: System.Reflection.BindingFlags at...

`internal protected` was not enough, I still had the error. Adding `[PhpHidden]` did the trick however!

Do you want me to modify it further, or is it good enough for now?

Hey @jakubmisek! Sorry for not getting back. I am swamped in work right now 😞 so as you could see I wasn't able to contribute as much as I could....

I've outlined in the PR description what is defined/what is missing. An exact list is available in the docs PR: https://github.com/peachpiecompiler/peachpie-docs/pull/5.

I will try starting something (like instanciating QUnit and building some basic tests). We will build incrementally from that :-)