dynamic-cli icon indicating copy to clipboard operation
dynamic-cli copied to clipboard

Replace HTML escape codes with corresponding ASCII character

Open pybash1 opened this issue 2 years ago • 12 comments

💥 Proposal

I have noticed that when searching, things like ' are shown as ' or " as ". Maybe a simple text replacer that replaces the HTML codes with the corresponding ASCII character. Maybe the common ones at least if not all.

Have you read the Contributing Guidelines on Pull Requests?

Yes

pybash1 avatar Apr 11 '22 13:04 pybash1

@pybash1 Thanks for pointing out. So, Do you have any plan to showcase us before implementing?

GouravSardana avatar Apr 12 '22 07:04 GouravSardana

@GouravSardana Um, showcase what it should look like after being implemented? Sure.

Sorry for such a late reply.

pybash1 avatar May 31 '22 03:05 pybash1

Yep

GouravSardana avatar May 31 '22 04:05 GouravSardana

I would like to work on it

nitin-pandita avatar May 06 '23 09:05 nitin-pandita

Sorry for being late, but since the status is still open I would like to work on it

Blackmamoth avatar May 18 '23 09:05 Blackmamoth

Hi @GouravSardana I would really like to work on this issue and replace HTML escape codes with corresponding ASCII character. Please assign this issue to me. I am a contributor of GSSOC'23.

A15h avatar May 20 '23 05:05 A15h

@Blackmamoth done. Assigned it to you

GouravSardana avatar Jun 04 '23 11:06 GouravSardana

Thank you @GouravSardana.

Blackmamoth avatar Jun 04 '23 16:06 Blackmamoth

Hello, @GouravSardana It's been 4 days since my pull request, it still hasn't been merged. Is there an issue that I need to fix?

Blackmamoth avatar Jun 08 '23 07:06 Blackmamoth

@Blackmamoth code scanning is failing. Please fix it

GouravSardana avatar Jun 08 '23 08:06 GouravSardana

Ok will do

Blackmamoth avatar Jun 08 '23 08:06 Blackmamoth

@GouravSardana done

Blackmamoth avatar Jun 08 '23 09:06 Blackmamoth