tree-sitter-just icon indicating copy to clipboard operation
tree-sitter-just copied to clipboard

Update Helix with the latest queries

Open tgross35 opened this issue 1 year ago • 3 comments

This grammar has gotten quite a bit better and Helix can probably update. The change for this just means bumping the checkout version and updating the queries - the queries in queries-src/ should be what is needed.

It would be great to have some Helix people review those queries too. If they have any changes, please let me know so we can get them upstream.

tgross35 avatar Feb 22 '24 18:02 tgross35

I actually wanted to do this about a month ago, but then I noticed it was crashing, so I put the task on hold. I would like to update queries in the helix repository, but when the injection detection gets better. Does it detect "bash" now as it did in 5766e756ff5bfe9caddeb8c5fe369558f5dc5092..e4e24050c061faf7a767310b9dfc391d576d2df1 which were reverted?

woojiq avatar Mar 02 '24 19:03 woojiq

Hey, thanks for the interest! It currently detects the recipe language via shebangs but does not have a fallback. This is partially because precedence is kind of in a confusing state now - nvim and zed use last-wins, TS just changed to also use last-wins, and helix is hopefully changing pretty soon https://github.com/helix-editor/helix/issues/9436.

But it is easy enough to add, I will do that soon.

tgross35 avatar Mar 03 '24 03:03 tgross35

@woojiq I actually went ahead and got this started https://github.com/helix-editor/helix/pull/9850, figured that's probably easiest for the first time since I can make any changes needed here quicker.

tgross35 avatar Mar 11 '24 22:03 tgross35

My PR was superseded, the update is complete!

tgross35 avatar Jul 28 '24 18:07 tgross35