InboxSDK icon indicating copy to clipboard operation
InboxSDK copied to clipboard

Failed to find element with selector: .aoP .aDh > table

Open tombenattar opened this issue 2 years ago • 6 comments

Some of our customers get using https://github.com/InboxSDK/InboxSDK/pull/934

Failed to find element with selector: .aoP .aDh > table

../../../node_modules/@inboxsdk/core/inboxsdk.js in GmailTooltipView._setupElement at line 10293:20 ../../../node_modules/@inboxsdk/core/inboxsdk.js in ga.getBottomBarTable at line 5482:71 ../../../node_modules/@inboxsdk/core/inboxsdk.js in GmailComposeView.setTitleBarText at line 7848:30 ../../../node_modules/@sentry/browser/node_modules/@sentry/utils/esm/envelope.js in serializeEnvelope at line 83:43

image

tombenattar avatar Jul 06 '23 03:07 tombenattar

We also have Failed to find element with selector: td div.yW

../../../node_modules/@inboxsdk/core/inboxsdk.js in new GmailActionButtonView at line 8917:31 ../../../node_modules/@inboxsdk/core/inboxsdk.js in getTitleHTMLString at line 20434:95 ../../../node_modules/@inboxsdk/core/inboxsdk.js in new GmailActionButtonView at line 8917:31 ../../../node_modules/@inboxsdk/core/inboxsdk.js in GmailAttachmentCardView._createNewElement at line 13761:38 ../../../node_modules/@inboxsdk/core/inboxsdk.js in s0._add at line 41020:1 ../../../node_modules/@inboxsdk/core/inboxsdk.js in s0._handleMain at line 41020:1 ../../../node_modules/@inboxsdk/core/inboxsdk.js in _$handleMain at line 41020:1 ../../../node_modules/@inboxsdk/core/inboxsdk.js in L at line 41020:1 ../../../node_modules/@inboxsdk/core/inboxsdk.js in F.dispatch at line 41020:1 ../../../node_modules/@inboxsdk/core/inboxsdk.js in ve._emitValue at line 41020:1 ../../../node_modules/@inboxsdk/core/inboxsdk.js in ve._onTick at line 41020:1 ../../../node_modules/@inboxsdk/core/inboxsdk.js in _$onTick at line 41020:1 ../../../node_modules/@sentry/browser/node_modules/@sentry/utils/esm/envelope.js in serializeEnvelope at line 83:43 ../../../node_modules/@inboxsdk/core/inboxsdk.js in _getChipElement at line 11927:111

tombenattar avatar Jul 06 '23 03:07 tombenattar

Let's focus on Failed to find element with selector: .aoP .aDh > table in this issue. #942 can be for the other one.

wegry avatar Jul 06 '23 11:07 wegry

At Streak, our main project has at least 45 occurrences of this selector failing in the last two weeks.

wegry avatar Jul 06 '23 11:07 wegry

At least for us, it seems like we have 3 users making up something like 85% of these errors in the last two weeks. I suspect this error is caused by another extension that modifies Gmail's ComposeView.

wegry avatar Jul 31 '23 19:07 wegry

Some notes

Still seeing a fairly limited subset of users experiencing this issue for Streak. One commonality between our top users seeing the issue is they have the "Gmail Settings Extender" extension installed.

Implementation notes

The call site that's throwing: https://github.com/InboxSDK/InboxSDK/blob/cef0c1ad7f5c20a2e36b7be4ddbf138599b5b4e4/src/platform-implementation-js/dom-driver/gmail/views/gmail-compose-view.ts#L1501

This ViewDriver method is only called in src/platform-implementation-js/dom-driver/gmail/views/gmail-compose-view/manage-button-grouping.ts. The SDK's custom ComposeView Button handling logic resides in there. Button grouping was tweaked to rely less on the method above here.

wegry avatar Aug 16 '23 12:08 wegry

Of the four users this issue seems to be affecting in the last two weeks, none of them are considered CRM active at Streak in the last 90D.

wegry avatar Aug 22 '23 17:08 wegry