dsm-storybook-example-library icon indicating copy to clipboard operation
dsm-storybook-example-library copied to clipboard

angular examples not working with 0.0.133 and 0.0.134

Open steflen opened this issue 3 years ago • 2 comments

angular-v5-example

  1. checkout this repo ...
  2. cd angular/storybook-v5
  3. yarn install
  4. yarn storybook => fail
Uncaught SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data

to fix => tag version to "@invisionapp/dsm-storybook": "0.0.132",

  • using node v12.16.3
  • process.env.STORYBOOK_DSM => undefined

steflen avatar Sep 22 '20 14:09 steflen

btw.

branch storybook-6-support => angular-v6 example also broken after checking out for versions 0.0.134 and 0.0.133

Uncaught UnsupportedVersionError: Unsupported @Storybook version (undefined). 
    @invisionapp/dsm-storybook plugin does not support this version of Storybook.

for versions 0.0.132

Uncaught TypeError: Object(...) is not a function
    at Module../.storybook/manager.js (main.73ced30….bundle.js:52)
/**
 * To override @invisionapp/dsm-storybook custom options/theme you can use Storybook options parameter and theming
 * -- this will only override the specific parameters you change --
 * options: https://storybook.js.org/docs/react/configure/features-and-behavior
 * theming: https://storybook.js.org/docs/react/configure/theming
 * Example code below
 **/
//  addons.setConfig({
//   ...getDsmOptions(process.env.STORYBOOK_DSM),
//   showNav: true,
//   theme: {
//     ...getDsmTheme(process.env.STORYBOOK_DSM),
//     colorPrimary: '#123456'
//   }
//  });

_storybook_addons__WEBPACK_IMPORTED_MODULE_0__["addons"].setConfig(Object.assign({}, Object(_invisionapp_dsm_storybook__WEBPACK_IMPORTED_MODULE_1__["getDsmOptions"])(Object({"NODE_ENV":"development","NODE_PATH":"","PUBLIC_URL":""}).STORYBOOK_DSM)));

process.env.STORYBOOK_DSM is undefined ...

i cant remember there is some documentation about that env var...

also the export "withDsm" seems to not exist ... ?

//in preview.js
import { withDsm } from '@invisionapp/dsm-storybook';

i'm enterprise user, developer -> linux (no mac, no sketch, no craft etc)

steflen avatar Sep 22 '20 14:09 steflen

after downgrading, re-upgrading and deleting some dependencies i managed to get it "running" after hours ..

then "dsm-storybook publish" was working exactly ONE time (without static assets folder), then i tried again "dsm-storybook publish -s staticFolder", then it stopped working ... it just hangs after compilation (where asset upload should kick in)

tried out more different configurations, checked my connections ... no clue

==> I'm not posting any reproducables here, as i'm quite sure these issues are known. (e.g. try this repo)

I'm sorry that this issue-thread has evolved into a an overall feedback now, but: For paid software I was expecting more. I just can not try this harder now .. instead the solution will be to host storybook inside our company's network and focus on actual work.

Pls keep on fixing that, I will check back in a few months. The overall idea of inivion-dsm - to have design and implementation preview in one versioned place - is a very good one.

steflen avatar Sep 23 '20 06:09 steflen