omnibus icon indicating copy to clipboard operation
omnibus copied to clipboard

Make Python3.6+ compliant

Open deadbits opened this issue 7 years ago • 4 comments

To get a wider user base and ensure we can support both Python2.7 and Python3.6+, we'll need to make some changes:

  • [ ] Ensure all dependencies from requirements.txt are Py3.6+ compatible
  • [x] Ensure all exceptions are handled correctly
  • [x] Handle print as print(foo) versus print foo
  • [x] Use fstrings and new format method in places where it makes sense:
  • [ ] ...
  • [ ] ... ongoing as I find more requirements
new: info(f'{artifact} tags: {result}')

original: info('%s tags: %s' % (artifact, result))
new: 
build_version = 'v{}.{}-{}_{}'.format(__app_major, rev_count.strip(), rev_hash.strip(), __app_stage)
app_version = 'v{}.{}_{}'.format(__app_major, rev_count.strip(), __app_stage)

old:
build_version = 'v%s.%s-%s_%s' % (__app_major, rev_count.strip(), rev_hash.strip(), __app_stage)
app_version = 'v%s.%s_%s' % (__app_major, rev_count.strip(), __app_stage)

deadbits avatar Aug 28 '18 12:08 deadbits

If this issue isn't resolved, this project is dead

q2dg avatar Aug 02 '20 22:08 q2dg

Hey @q2dg , I'll see if I can add py3 compatibility to this project.

cmmorrow avatar Aug 03 '20 08:08 cmmorrow

Hey all,

I will happily merge any PRs for Py3 compatability and I definitely appreciate the interest in this project. Unfortunately I haven't had much time to activately maintain this- I hope this changes in the near future, but anything I can do to facilitate support here let me know

deadbits avatar Aug 04 '20 11:08 deadbits

Starting on this now. I'll keep everyone updated on the status.

cmmorrow avatar Aug 10 '20 00:08 cmmorrow