ThreatKB icon indicating copy to clipboard operation
ThreatKB copied to clipboard

Published 20 hours ago • verified publisher icon InQuest

Add the ability to revert to a previous version of a yara rule in the UI

Open danny248 opened this issue 4 years ago • 3 comments

danny248 avatar Jul 03 '20 17:07 danny248

@danny248 Done. https://github.com/InQuest/ThreatKB/pull/382

I added some comments. Please review.

dcuellar322 avatar Jul 06 '20 03:07 dcuellar322

We were unable to validate this feature; we can see how to view revisions in the UI, can perform and view diffs between versions, but don't seem to see a way to revert to a previous revision. Not completely sure how this would be visible in the UI.

@WillyMac indicated that this was implemented at some point in the past, but seems to have been either changed or removed or perhaps affected by a regression.

@dcuellar322 We'd like to take another look at this one if we can, as the capability to roll back to a previous revision is an important one and in a future state where we replace signature management in ThreatKB with a GitHub driven approach, we'd have this capability there (native VCS revision control based reverts). We might be missing something, but don't think we see this in the UI.

dspruell-i01 avatar Mar 11 '24 18:03 dspruell-i01

@dspruell-i01 That's definitely weird. I don't see the ability either. I don't know what happened to my previous code. It was merged into staging almost 4 years ago lol.

I can reference the MR and reimplement.

dcuellar322 avatar Apr 04 '24 05:04 dcuellar322