GUIslice icon indicating copy to clipboard operation
GUIslice copied to clipboard

Added touch flip flags to TFT_eSPI driver.

Open tpitman opened this issue 4 years ago • 5 comments

I don't know if this is the right way to do this, but it is the way that works for me. I am creating this pull request knowing full well that you might come up with a better way. I need the touch to be rotated independent of the screen graphics and don't see a way to do one without the other. So adding these flags lets me rotate just the touch input.

tpitman avatar Aug 26 '20 00:08 tpitman

Hi Tony — in general, the calibration was supposed to take care of the display vs touch orientation so it is interesting to find a case where we need an additional flip setting. It could very well be needed!

Just so that I understand your particular device setup and rule out any calibration issues, can you confirm the following:

  • Which touch driver are you using?
  • If it was a resistive touch panel, can you attach the output of the diag_ard_touch_calib calibration sketch?

Thanks!

ImpulseAdventure avatar Aug 26 '20 04:08 ImpulseAdventure

I am using the FT6236 hardware and I have the FT6206 selected in the configuration files.

My screen is not rotated at all, but both x and y are flipped.

On Tue, Aug 25, 2020 at 10:20 PM Calvin Hass [email protected] wrote:

Hi Tony — in general, the calibration was supposed to take care of the display vs touch orientation so it is interesting to find a case where we need an additional flip setting. It could very well be needed!

Just so that I understand your particular device setup and rule out any calibration issues, can you confirm the following:

  • Which touch driver are you using?
  • If it was a resistive touch panel, can you attach the output of the diag_ard_touch_calib calibration sketch?

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ImpulseAdventure/GUIslice/pull/249#issuecomment-680573793, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWFTQ7IG45Z6U76X7EWMXLSCSESVANCNFSM4QLGWBRQ .

tpitman avatar Aug 26 '20 04:08 tpitman

Thanks Tony... yes, we might need to apply some additional options to support your particular capacitive display.

Could you run the following test for me?

  • Load examples/arduino/diag_ard_touch_calib
  • Modify (~ line 40): Comment out the #error Calibration only supported...
  • Modify (~ line 199): Change DET_RAW_RANGE_MIN to 150
  • Run the first 5 steps of the calibration (pressing on each cross-hair)
  • Please paste or attach the serial monitor output to this issue

Thanks!

ImpulseAdventure avatar Aug 27 '20 06:08 ImpulseAdventure

Hi @tpitman — we can certainly add the ability to flip the capacitive touch orientations, much like you had proposed here.

The reason for my test request in https://github.com/ImpulseAdventure/GUIslice/pull/249#issuecomment-681624325 was to see if we can utilize the existing calibration sketch to detect the orientation settings automatically.

Thanks

ImpulseAdventure avatar Oct 20 '20 14:10 ImpulseAdventure

Sorry this is taking so long. Just got a lot going on and this is one project of many. I know you understand because you are in the same boat.

On Tue, Oct 20, 2020 at 8:13 AM Calvin Hass [email protected] wrote:

Hi @tpitman https://github.com/tpitman — we can certainly add the ability to flip the capacitive touch orientations, much like you had proposed here.

The reason for my test request in #249 (comment) https://github.com/ImpulseAdventure/GUIslice/pull/249#issuecomment-681624325 was to see if we can utilize the existing calibration sketch to detect the orientation settings automatically.

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ImpulseAdventure/GUIslice/pull/249#issuecomment-712882946, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWFTQ5HRHDWN3JQG2QRDN3SLWLIBANCNFSM4QLGWBRQ .

tpitman avatar Oct 20 '20 14:10 tpitman