impresscms icon indicating copy to clipboard operation
impresscms copied to clipboard

Published 20 hours ago • verified publisher icon ImpressCMS

use of removed $icmsModule througout the core

Open fiammybe opened this issue 1 year ago • 6 comments

the global variable $icmsModule is no longer available, and should be replaced by icms::$module. But I still see lots of places in the core where that variable is used.

fiammybe avatar Nov 14 '23 08:11 fiammybe

It's not so easy I fear. The $icmsModule variable is sometimes used internally, so it's not as easy as replacing them all with icms::$module :-(

fiammybe avatar Nov 14 '23 13:11 fiammybe

Yes, I have found places where it is defined and used - got to review them 1 by 1

skenow avatar Nov 14 '23 14:11 skenow

And I think I got quite a few of them changed while working on the PHP7/8 compliance

skenow avatar Nov 18 '23 16:11 skenow

I stand corrected - I just did a search and there are over 150 occurrences still left

skenow avatar Nov 18 '23 16:11 skenow

I tried migrating the ImpressCMS site to 2.0 RC2 and it bombed on me :-( Most of the issues will be the use of $icmsModule in the modules used on the site, but I'm going through the files to see if I can get it working on the beta site. After that, I can re-try the migration from a fresh dump. This is blocking for the 2.0 release I'm afraid.

fiammybe avatar Apr 29 '24 07:04 fiammybe

Looks like most of the issues I had with the migration of the ImpressCMS.org site were module related.

fiammybe avatar Jul 23 '24 08:07 fiammybe

this should be fixed by #1555 . If there are some more cases lingering about, they will surface in due course.

fiammybe avatar Sep 18 '24 21:09 fiammybe