impresscms icon indicating copy to clipboard operation
impresscms copied to clipboard

Forms should not be hard-coded to generate html tables

Open fiammybe opened this issue 2 years ago • 8 comments

When building the bulma theme, I was trying to generate a form following the bulma way of working, by adapting the system_common_form.html and system_default_form.html templates. Nothing happened. Looking into the icms library code, the render procedures of the icms_form_Theme and the icms_form_Simple classes simply generate hardcoded HTML tables with the element data. These procedures should be updated to make use of the Smarty templates that are available.

fiammybe avatar Jul 11 '22 09:07 fiammybe

If you use SASS compiler for CSS theme there is workaround -> @extend keyword.

But yea having such option in core would be great. And not only in 1.5.x but also in 2.0.x

MekDrop avatar Jul 11 '22 10:07 MekDrop

See #85

skenow avatar Jul 29 '22 17:07 skenow

Gosh, this goes back a long time. Let's see if I can get this darn template working in the next few days. The thing is that a template exists in the system module, it just isn't used.

fiammybe avatar Jul 31 '22 15:07 fiammybe

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

github-actions[bot] avatar Oct 01 '22 04:10 github-actions[bot]

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Oct 11 '22 03:10 github-actions[bot]

I have been looking into this on-and-off between other more pressing tasks. I found out that most of the forms templates that are available simply are not used by the core :-(

fiammybe avatar Oct 11 '22 06:10 fiammybe

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

github-actions[bot] avatar Dec 11 '22 02:12 github-actions[bot]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or assign sombody or this will be closed in 5 days.

github-actions[bot] avatar Feb 11 '23 02:02 github-actions[bot]