Nuklear icon indicating copy to clipboard operation
Nuklear copied to clipboard

Add a style option to disable point markers on charts

Open brianwatling opened this issue 1 year ago • 2 comments

With point markers enabled (default): with_markers With point markers disabled: without_markers

Fixes #594

brianwatling avatar Jan 05 '24 02:01 brianwatling

Looks good to me in general. My personal preference would be to use a non-negated form (nk_bool show_markers; instead of nk_bool hide_markers;) but I would be fine merging if others will not agree :wink:.

dumblob avatar Feb 17 '24 16:02 dumblob

That's a good point. Would it be possible to default nk_bool show_markers to nk_true when initializing the struct?

RobLoach avatar Feb 17 '24 18:02 RobLoach

That's a good point. Would it be possible to default nk_bool show_markers to nk_true when initializing the struct?

Done - renamed to show_markers and defaults to nk_true to preserve existing default behaviour (and tested that)

brianwatling avatar Feb 27 '24 04:02 brianwatling