Nuklear Modify Appearance of Option/Checkbox

This is basically https://github.com/vurtun/nuklear/pull/653 from zhouxs1023 so all credit there. Followed the discussion #222 and this is something I also need so ported the change from zhouxs1023 to here because I have some time today.

tested it out and looks good to me. check_and_radio

Jun 17 '22 11:06 RobertLemmens

I wonder how is it with radios? Both shall behave visually "the same".

Also thinking about this I am not sure whether the originating issue lies simply within a reversed boolean coming from the checkbox/radio widgets. If we reversed the boolean meaning then I think the current style in master branch would be OK, right?

Jun 17 '22 12:06 dumblob

Yes radio also looks the same, here is a selected radio: nuklear_radio

I honestly think that this is much better compared to the old styling (especially radio): check_old

It is much more clear that it is selected because of the visible border around the inset fill, like there is a "container", and there's something visibly inside of it (selected). the darker fill in the old one confuses me allot

If we take a look at other radio implementations around the web they usually all behave in this PRs way making it extremely clear to the user what is going on: radio_example radio_example2 radio_example3

when it is a fill color it is usually paired with some other visual indicator, like a dot or a checkmark like here: fill_example

Checkbox is more often done with a real checkmark but I think we should just keep it in sync with radio instead of adding a real checkmark. User can add image for this for now.

Jun 17 '22 13:06 RobertLemmens

I do think however that the background also impacts this allot!

Jun 17 '22 13:06 RobertLemmens

I like this change, but it looks a bit off-center on some of the other demos... Could likely be something else that's affecting that :thinking: This is x11_rawfb