Nuklear icon indicating copy to clipboard operation
Nuklear copied to clipboard

Fixing scaling and position of horizontal scrollbar when scaling left

Open RobLoach opened this issue 2 years ago • 4 comments

@MikemathuKE @dumblob Cherry picked the commits in, but am in no way qualified to test this.

Fixes #219

RobLoach avatar Dec 14 '21 12:12 RobLoach

LGTM

Maybe what about adding a comment to the source code about the "priority" problem? Quoting @MikemathuKE:

Unfortunately, I could not scale since the horizontal scrollbar was given priority. Therefore I fixed it by moving the position of the horizontal scrollbar so that it doesn't overlap with the scaler.

dumblob avatar Dec 14 '21 13:12 dumblob

@RobLoach do you think the (currently missing :wink:) comment would make it clear?

dumblob avatar Dec 17 '21 08:12 dumblob

I have no context into the issue or what could improve it. :shrug:

RobLoach avatar Dec 19 '21 07:12 RobLoach

LGTM. Let's bump the version and merge!

dumblob avatar Dec 22 '21 22:12 dumblob