Nuklear icon indicating copy to clipboard operation
Nuklear copied to clipboard

Add Newline Character Handling to nk_text/nk_label

Open zgcrowno opened this issue 4 years ago • 6 comments

This is a newline handling implementation originally written by @AntiBlueQuirk, but which was never merged into the old Vurtun library for some reason. I've been very pleased with the results so far, but would obviously love feedback on potential issues I may have overlooked when bringing over this implementation.

zgcrowno avatar Jun 16 '20 21:06 zgcrowno

I haven't tested the code, but I've read through it. The code looks good to me though :+1:

Hejsil avatar Jun 27 '20 18:06 Hejsil

Thanks for taking the time to look this over, @Hejsil!

zgcrowno avatar Jun 29 '20 14:06 zgcrowno

@dumblob, is this functionality something you're still interested in?

zgcrowno avatar Jul 23 '20 22:07 zgcrowno

Ehm, it's pretty important feature and this is march 2021, feels like this repo died

krupitskas avatar Mar 18 '21 13:03 krupitskas

I'll chime in quickly just to say I'm sorry for not devoting any time lately to Nuklear (I'm too busy with family life).

I'd like to say though, that I don't think this repo is dead. It's just slow. Any new reviewers are welcome (after a good review or two they'll get full access to this repository and are encouraged to recruit other new reviewers).

dumblob avatar Mar 18 '21 14:03 dumblob

Seeing this at this time I'm playing with the idea to declare the current behavior of nk_text_wrap and nk_widget_text_wrap as faulty and just change their behavior to not only wrap on newlines but also on word boundaries. Instead of providing yet another API (multiline functions) which'll presumably subsume probably all existing use cases of the wrap functions.

Thoughts?

dumblob avatar Dec 22 '21 20:12 dumblob