Imbris

Results 125 comments of Imbris

Change precedence of `build-override`

Squashed :slightly_smiling_face:

Change precedence of `build-override`

This might be a bit of a sidetrack, but IMO it is already a bit unintuitive that workspace members are excluded from `*`. > What is the likelihood we'd expand...

Change precedence of `build-override`

> This makes me realize the current changes would still leave no way to specifically configure `` as a regular dependency without also affecting its configuration when used as a...

Remove `Clone` bound on `user_data` since that is implied by the `Copy` bound

Please feel free to close if this change isn't desired.

Using `acos` in some methods leads to NaNs if the two vecs are near identical

For slerping I mentioned the issue with two vectors pointing in the same or opposite directions because I realized while writing that this coincides with the case where the dot...

Serde behavior for some deserializers with Option and missing fields is counterintuitive

Hi! I just encountered this issue as well. For my case have configuration files based on structs that are generated from a corresponding enum with a field for each variant....

get_mut_unchecked missing from documentation

This appears to have been fixed by https://github.com/amethyst/specs/pull/700 which exposes `PairedStorage` however this is not yet in a released version.

Allow components to perform cleanup (with access to the World) when they are removed

I think the main barrier here is that typically other parts of the world can be borrowed mutably and immutably while removing components from a particular storage.

Re-export all of Shrev

The whole shrev crate is re-exported as `specs::shrev`: https://docs.rs/specs/0.16.1/specs/#reexports Is this sufficient?

this is more of a question

There are plans to make the map bigger but not infinite, also see https://book.veloren.net/players/faq.html#is-the-map-infinite