slim
slim copied to clipboard
ImagingDataCommons
Improve handling of missing slide label and overview images
Suggested by @ulrikew
I have a feature request for the Slim viewer: Can the empty space for slide label be removed or be filled with a dummy image that states Not available or something similar?
Another feature request: Can the same be done for the thumbnail images on the left side that allow users to go to the other slides of the same patient? We have a lot of space that doesn't serve any purpose. All new CCDI MCI images will lack label and thumbnail images and this problem will persist.
@pedrokohler it appears that when there is label/thumbnail image, they are now not shown in Slim.
See this for example: https://viewer.imaging.datacommons.cancer.gov/slim/studies/2.25.211094631316408413440371843585977094852/series/1.3.6.1.4.1.5962.99.1.208792987.352384958.1640886332827.2.0
@fedorov
It looks like the mechanism for detecting and displaying thumbnails is broken.
I reverted my recent changes and confirmed that the thumbnails were not shown in slim immediately before my changes.
I also tried rolling back to the earliest versions, but I couldn’t get them running on my machine—likely due to Node version compatibility issues, which I haven’t been able to resolve yet.
If you’d like, I can spend more time investigating whether thumbnails ever worked and, if so, try to restore that functionality. However, based on my findings, it seems like this feature was never fully functional. Additionally, I don’t fully understand the original author’s approach to rendering thumbnails.
To implement thumbnail support from scratch, I estimate it would take approximately 3 to 4 days of work, as the current implementation is unclear to me. However, since Igor has more experience with slim and dicom-microscopy-viewer, he might be able to address this more efficiently.
Let me know how you’d like to proceed.
I am confident it was working at some point. This is how it is supposed to look: https://github.com/ImagingDataCommons/slim/blob/master/docs/screenshots/IDC_CPTAC_C3N-01016-22_annotation.png.
Testing of this is a bit tricky, since you need to make sure that the DICOM series you are visualizing contains the OVERVIEW image - I am not sure it is present in every series.
Here's one example where that image is indeed present: https://viewer.imaging.datacommons.cancer.gov/slim/studies/2.25.211094631316408413440371843585977094852/series/1.3.6.1.4.1.5962.99.1.208792987.352384958.1640886332827.2.0
And you can confirm this by opening the series in QuPath and looking at the items available in the Image tab / Associated images.
@igoroctaviano can you take a look at this, and also test with a version before the potentially breaking change in https://github.com/ImagingDataCommons/slim/commit/155e0018c2fd8b87eee70c207051de9df55f0ada?
@igoroctaviano this is very nice, thank you!
Nitpick: how difficult would it be to disable zoom on the overview slides in the sidebar?
@igoroctaviano this is very nice, thank you!
Nitpick: how difficult would it be to disable zoom on the overview slides in the sidebar?
I didn't know we had Zoom there hahaha. Funny thumbnail. I think its because the thumbnail is a sub-type of a viewport. I'll see what I can do. It shouldn't be tricky.
To address the original concern from @ulrikew, I asked @igoroctaviano to add "SM" (value of the Modality attribute) for those thumbnails where overview image is not available. This will bring Slim in line with the conventions implemented in OHIF, which seem to be intuitive and logical.
I didn't know we had Zoom there hahaha. Funny thumbnail. I think its because the thumbnail is a sub-type of a viewport. I'll see what I can do. It shouldn't be tricky.
@igoroctaviano looks great so far, but I note that zoom on overview image is still enabled!
I didn't know we had Zoom there hahaha. Funny thumbnail. I think its because the thumbnail is a sub-type of a viewport. I'll see what I can do. It shouldn't be tricky.
@igoroctaviano looks great so far, but I note that zoom on overview image is still enabled!
Can you describe how you managed to change the zoom? here I can't interact with the thumbnail.
@igoroctaviano it is now in IDC prod tier: https://viewer.imaging.datacommons.cancer.gov/slim/studies/2.25.211094631316408413440371843585977094852/series/1.3.6.1.4.1.5962.99.1.208792987.352384958.1640886332827.2.0
You just mouse over the thumbnail, and roll the mouse wheel!
/slim/studies/2.25.211094631316408413440371843585977094852/series/1.3.6.1.4.1.5962.99.1.208792987.352384958.1640886332827.2.0
@fedorov I can't reproduce it here: https://dev-viewer.canceridc.dev/slim/studies/2.25.211094631316408413440371843585977094852/series/1.3.6.1.4.1.5962.99.1.208792987.352384958.1640886332827.2.0
Any thoughts?
@igoroctaviano in dev, there is another issue - the image does not show up at all. I think you were going to follow up on the thread here https://cornerstonejs.slack.com/archives/GP0DDMVMF/p1747758320549579?thread_ts=1747334409.153409&cid=GP0DDMVMF.
@igoroctaviano in dev, there is another issue - the image does not show up at all. I think you were going to follow up on the thread here https://cornerstonejs.slack.com/archives/GP0DDMVMF/p1747758320549579?thread_ts=1747334409.153409&cid=GP0DDMVMF.
It does render locally and prod: https://viewer.imaging.datacommons.cancer.gov/slim/studies/2.25.118828354172313341333054829055023191565/series/1.3.6.1.4.1.5962.99.1.1222904558.520497373.1714914888430.4.0
dev is broken because of the DMV build config update, which is unrelated to this issue.