dicom-microscopy-viewer icon indicating copy to clipboard operation
dicom-microscopy-viewer copied to clipboard

Add errorinterceptor argument to propagate error to the top level app

Open GitanjaliChhetri opened this issue 2 years ago • 4 comments

Errors thrown in viewer.js can now be propagated to the Slim Viewer App. Changes needed for https://github.com/herrmannlab/slim/pull/134

GitanjaliChhetri avatar Nov 19 '22 05:11 GitanjaliChhetri

@hackermd I do not seem to have permissions to add reviewers to this PR. Please know it's ready for your review. Thanks!

GitanjaliChhetri avatar Nov 28 '22 16:11 GitanjaliChhetri

@hackermd I have addressed the requested changes. Please let me know if this can be merged? Thank you.

GitanjaliChhetri avatar Jan 19 '23 22:01 GitanjaliChhetri

@GitanjaliChhetri @fedorov got the status checks working.

hackermd avatar Jan 28 '23 11:01 hackermd

@hackermd can you please re-review? Per @GitanjaliChhetri, all of your concerns should now be addressed.

fedorov avatar Feb 10 '23 21:02 fedorov