Rodrigo Leitão

Results 81 comments of Rodrigo Leitão
trafficstars

Node v18 has now been released and fetch is declared globally without any flags. Can we switch to node's version of fetch now and release a new major version along...

> Regarding helper methods - the library already provides the solution for fetching all items in a list instead of creating loops on a client-side: Oh alright that's my bad,...

I think this proposal can also be split into two PRs if accepted: - One semver minor PR where method inputs are standardized (objects for optional parameters) and old overloads...

> For other utility methods we do have a dedicated library crowdin/crowdin-apps-functions. I feel like that package is more for OAuth2 apps and not just pure Crowdin API, or at...

I’m not rushing it, but with that PR merged the next version release will have to be v2.0.0 if it includes that commit so I believe it would be nice...

But the current version is 1.15.2 ? Why that specifically and why isn’t this a breaking change?

> It appears that the /locraw message is always captured and cancelled unless the player sent it. The command is also canceled when the player runs it but this seems...

> Not that this is the only solution but I believe forge has a tag where you can have canceled events still flow into your event handler This could fix...

That’s not needed, they just need to fix their checks which are already implemented

Because the check they tried to implement is broken and cancels the command completely, even if it’s ran by the user