HSPlugins icon indicating copy to clipboard operation
HSPlugins copied to clipboard

[PE] Removed "Link same name" from BlendshapeEditor module.

Open ShalltyB opened this issue 10 months ago • 3 comments

Hi, I wanted to ask why was the feature to link blendshapes with the same name that was added in #104 has been removed in #112 . The interpolable was kept, but the toggle and the function itself were removed so it cant be used properly, is there any reason for that?

ShalltyB avatar Feb 26 '25 17:02 ShalltyB

@ReafLife

ManlyMarco avatar Feb 27 '25 08:02 ManlyMarco

@ManlyMarco I just checked the alert. I plan to review the issue and get back to you by this weekend.

ReafLife avatar Apr 25 '25 09:04 ReafLife

I'm not very familiar with using GitHub, and it seems that the feature you added was removed while I was in the middle of modifying the _linkEyesComponents code. Also, is the "Link same name" feature intended to replace _linkEyesComponents? From the example screenshot you provided, it appears that _linkEyesComponents has been removed and only the "Link same name" toggle is available. While this approach may work fine in KK, it would cause significant issues in HS2. If this method is specifically intended for KK, I believe the related code should be completely separated for HS2 to avoid serious problems.

ReafLife avatar Apr 29 '25 12:04 ReafLife