react-navigation-shared-element icon indicating copy to clipboard operation
react-navigation-shared-element copied to clipboard

[v5] - iOS gestures

Open davesimtech opened this issue 4 years ago • 3 comments

Firstly I'd like to thank everyone involved for getting this awesome library to work with react-navigation v5!

Not sure if this is a bug or if it is working as intended - however the animation between screens doesn't work when using gestures on iOS.

recording

davesimtech avatar Apr 09 '20 20:04 davesimtech

I've noticed this issue too. The cardInterpolatorStyle will be called when using gestures, I tried to play around and render the SharedElement transition there but I haven't found a way to do so. I've found this article on how it would work: http://www.reactnativediary.com/2017/04/22/react-navigation-shared-element-transition-3.html

Anyone knows how to get working gesture transitions? The gesture transition looks pretty ugly since I'm animating the opacity property in my cardInterpolatorStyle...

mrousavy avatar Apr 14 '20 11:04 mrousavy

I thought I'd revisit this issue this week and have created a fork which enables transitions on gesture. There is still some bugginess that I'm hoping to resolve, but it would be great to get another pair of eyes on it.

https://github.com/davesimtech/react-navigation-shared-element

davesimtech avatar Mar 30 '22 15:03 davesimtech

@davesimtech thank you for working on this issue. Can you create a PR from your fork? It will be easier to see what changes you made.

p-syche avatar Aug 09 '22 14:08 p-syche