igniteui-webcomponents icon indicating copy to clipboard operation
igniteui-webcomponents copied to clipboard

refactor(nav-drawer): update themes

Open desig9stein opened this issue 10 months ago • 4 comments

closes #1152

desig9stein avatar Apr 18 '24 07:04 desig9stein

Comments are still not resolved.

didimmova avatar Apr 22 '24 09:04 didimmova

In Light Fluent theme, the icon of the item should be primary-500, when idle, now it's primary-700

didimmova avatar Apr 23 '24 04:04 didimmova

Are we going to implement the sizes of the mini navdrawer? I suggest putting a min-width on it that is the size of the smallest one (fluent) and it will grow according to the padding and icon size.

didimmova avatar Apr 23 '24 05:04 didimmova

The border of the navdrawer is all around only in fluent. All other themes have a border only on the inline-end side.

didimmova avatar Apr 23 '24 05:04 didimmova

Bootstrap:

  • Border should be inside. The total width of the mini should be 88px.
  • The total width of the default one should be 240px (including the border).
  • Background color on hover should be grays.200 80% in dark mode.

imincheva avatar May 16 '24 12:05 imincheva

Material

The border should be inside. The total width of the mini should be 56px. The total width of the default one should be 240px (including the border).

AnjiManova avatar May 16 '24 12:05 AnjiManova

Fluent

  • For both light and dark modes, default open and mini variants the border of the whole component should be positioned inside. Now, it is outside and the width of the whole component grows with a couple of pixels. For the open default nav drawer the width should be 240px (+ border) and 40px (+ border) width for the mini variant .

sbayreva avatar May 16 '24 13:05 sbayreva

Indigo

  • The nav drawer should have 8px padding on all sides

imincheva avatar May 20 '24 09:05 imincheva