igniteui-cli icon indicating copy to clipboard operation
igniteui-cli copied to clipboard

Web components projects should use the general TypeScriptFileUpdate.ts

Open dafo opened this issue 3 years ago • 4 comments

Description

Currently web components projects use own TypeScriptFileUpdate.ts file, located inside their own folder. It duplicates much of the logic inside the "general" file placed under "packages/core/typescript". All projects must use the general file. It should be updated to support generation of project different than Angular. N. B. The logic should be platform agnostic. Where we check for Ng stuff - we should set it as parameters instead of looking what platform the generated project is.

We should refactor the addRoute method. This method is actually doing two things, at least. It adds routes as well as it adds imports. We should try to split this into two separate methods. Note, to do this we may need to create separate visitor for imports and routes. - https://github.com/IgniteUI/igniteui-cli/pull/1060#discussion_r988903737

  • Ignite UI CLI version: 9.x.x
  • Framework: Web Components
  • Project type: igc-ts

dafo avatar Jan 24 '22 09:01 dafo

https://github.com/IgniteUI/igniteui-cli/pull/1060#discussion_r988903737

dafo avatar Oct 07 '22 07:10 dafo

There has been no recent activity and this issue has been marked inactive.

github-actions[bot] avatar Mar 29 '23 22:03 github-actions[bot]

There has been no recent activity and this issue has been marked inactive.

github-actions[bot] avatar Jan 13 '24 22:01 github-actions[bot]

There has been no recent activity and this issue has been marked inactive.

github-actions[bot] avatar May 24 '24 22:05 github-actions[bot]