igniteui-cli icon indicating copy to clipboard operation
igniteui-cli copied to clipboard

Should upgrade cli command update vite.config?

Open mddragnev opened this issue 7 months ago • 4 comments

There might be some cases where we have trial package handling inside the vite config. For example:

export default defineConfig(({ mode }) => {
  return {
    plugins: [
      viteStaticCopy({
        targets: [
          {
            src: "node_modules/igniteui-webcomponents-grids/grids/themes/light/bootstrap.css",
            dest: "themes",
          },
          {
            src: "node_modules/igniteui-webcomponents-grids/grids/themes/light/fluent.css",
            dest: "themes",
          },
        ],
      }),
    ],
  };
});

When using ig upgrade-packages do you think that the cli should upgrade those references as well or is this a not so common edge case which we should not handle?

mddragnev avatar Apr 11 '25 07:04 mddragnev

@damyanpetev @Lipata @dkamburov

mddragnev avatar Apr 11 '25 07:04 mddragnev

There has been no recent activity and this issue has been marked inactive.

github-actions[bot] avatar Jun 10 '25 22:06 github-actions[bot]

I think those references should be updated by the schematics as well.

dkamburov avatar Jun 11 '25 06:06 dkamburov

I think those references should be updated by the schematics as well.

Yup, would be a nice to check that file and update just in case, but also especially if those are baked into the setup of the CLI projects as well? Which I think might need to be the case since those were needed to have those themes work property when app is built, right?

damyanpetev avatar Jun 11 '25 14:06 damyanpetev

There has been no recent activity and this issue has been marked inactive.

github-actions[bot] avatar Aug 10 '25 22:08 github-actions[bot]