igniteui-angular icon indicating copy to clipboard operation
igniteui-angular copied to clipboard

refactor(i18n): satisfies operator to validate resource string objects

Open damyanpetev opened this issue 5 months ago • 0 comments

Related to an issue in https://github.com/IgniteUI/igniteui-angular/pull/14562#issuecomment-2269161648 that had the expanded types fail to decompile away with newer 5.5 TypeScript, making the package dist invalid. Moving to the satisfies Operator since the whole ordeal with the resource types was needed to guarantee all properties match without emitting the type directly and that's what the operator is for now that it's available. Also, the error was not caught by the lint check since the global ignore was interfering, so fixed that as well.

Additional information (check all that apply):

  • [x] Bug fix
  • [ ] New functionality
  • [ ] Documentation
  • [ ] Demos
  • [x] CI/CD

Checklist:

  • [x] All relevant tags have been applied to this PR
  • [ ] This PR includes unit tests covering all the new code (test guidelines)
  • [ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
  • [ ] This PR includes feature/README.MD updates for the feature docs
  • [ ] This PR includes general feature table updates in the root README.MD
  • [ ] This PR includes CHANGELOG.MD updates for newly added functionality
  • [ ] This PR contains breaking changes
  • [ ] This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • [ ] This PR includes behavioral changes and the feature specification has been updated with them

damyanpetev avatar Sep 17 '24 12:09 damyanpetev