igniteui-angular icon indicating copy to clipboard operation
igniteui-angular copied to clipboard

Add template context guards for some directives

Open skrustev opened this issue 2 years ago • 2 comments

Closes #

Additional information (check all that apply):

  • [ ] Bug fix
  • [x] New functionality
  • [ ] Documentation
  • [ ] Demos
  • [ ] CI/CD

Checklist:

  • [ ] All relevant tags have been applied to this PR
  • [ ] This PR includes unit tests covering all the new code (test guidelines)
  • [ ] This PR includes API docs for newly added methods/properties (api docs guidelines)
  • [ ] This PR includes feature/README.MD updates for the feature docs
  • [ ] This PR includes general feature table updates in the root README.MD
  • [ ] This PR includes CHANGELOG.MD updates for newly added functionality
  • [ ] This PR contains breaking changes
  • [ ] This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • [ ] This PR includes behavioral changes and the feature specification has been updated with them

skrustev avatar Sep 14 '22 15:09 skrustev

@skrustev Maybe we could omit adding some of the context types if @dkamburov gonna log it as a separate issue.

mddragnev avatar Sep 19 '22 15:09 mddragnev

@skrustev Maybe we could omit adding some of the context types if @dkamburov gonna log it as a separate issue.

TemplateRef context types should be treated as a separate task

dkamburov avatar Sep 20 '22 07:09 dkamburov

@skrustev There is one more comment here. https://github.com/IgniteUI/igniteui-angular/pull/12081#discussion_r974351117

mddragnev avatar Sep 23 '22 13:09 mddragnev