ryot
ryot copied to clipboard
IgnisDa
Komga implementation
This appears to be working well in my testing and properly handles mass marking as read as well as marking in progress reading correctly. Needed to add in a special case in misc for a progress update where the chapter is provided out of order as occasionally apps like mihon appear to update this information in random order. This occasionally resulted in the wrong chapter being marked as read.
Looking good! Requested for a few small changes. Will take a better look when I get the time. Thanks!
Addressed a bug where some manga imported with a different number than is shown in the interface not sure what causes this but metadata.number is the authoritative number and is also the one that gets edited in the interface the original item.number appears to be the order in which they import into the series.
Not sure about this, but is your rust formatter working? Maybe you have to install rust-analyzer. None of the rust file changes you made are formatted, it seems.
The pro version also supports "Sync to Owned collection" boolean, will this be something this integration can support?
It appears my IDE had the formatter disabled I believe this has been resolved.
The pro version also supports "Sync to Owned collection" boolean, will this be something this integration can support?
How does this functionality work? Does it just add the things which are tracked to the owned collection or is this doing an import of all books into the owned collect?
As of now, it just works for ABS. It just adds all items in your library to the owned collection. Can I give you access to the Pro repo, and you can take a look at the code?
I'm currently using rustfmt is this the intended formatter or is there another you are using? I'm not 100% familiar with rust code formatting I'm traditionally a c++ programmer and we use other tools over there.
@Jacob-Tate Can you make an empty commit with Run CI somewhere in the commit message? I want to test if the correct docker images are released.
Do you know why the login step is failing?
cc @vnghia
EDIT: Seems like secrets are not accessible from forked repos. That kinda defeats the purpose of the entire dev workflow.
https://github.com/orgs/community/discussions/26163#discussioncomment-3250630
NOTE TO SELF: Add checks in the GH action to allow only mantainers to be able to trigger a workflow.
Ill get this upgraded to work with the refactor this weekend. Ive been running it for about a week on a personal instance and havent run into any issues.
I discovered its possible to pass the users komga credentials in a basic_auth field rather than requiring retrieving the users remeber-me cookie. Do you think we should use that instead?
Yes I think that would simplify usage for users as well. Obtaining the cookie requires a few steps.
Yes this should be ready ive been running it for a few days without any issues.