pflua
pflua copied to clipboard
Remove implicit conjunction
I thought that since "tcp port 80" should parse as "tcp and port 80" that in fact the implicit "and" that the pflang spec mentions as obsolete was in fact current. This faulty conclusion was based on my bad understanding of how "tcp port 80" parses -- that in fact as issue #15 indicates, "tcp port 80" is one operator.
So, we should remove the implicit conjunctions from the parser.
This is marked as high-priority, but hasn't been closed or merged despite being open for months. Is the underlying issue fixed, or does this patch need to be updated and applied?
@andywingo commented the proposed patch (remove the else branch) is not correct. I think that once the issue with parsing tcp port was fixed the else branch, that creates the implicit 'and', is no longer taken.