chromium icon indicating copy to clipboard operation
chromium copied to clipboard

Ozone wayland dev file dialog patches

Open jkim-julie opened this issue 7 years ago • 4 comments

This change is to reuse file manager from ChromeOS on Linux/ozone build.

It has steps below. - Have Separate string resources for file manager from ChromeOS strings resources. - Add several modules related to file manager to public folder from specific ChromeOS folder. - Add platform folder to manage it independently on platform as it has many features dependent on ChromeOS. - Add some guards to run ChromeOS specific code only on ChromeOS. - Bundle web resources to Linux build. - Implement FileSelection dialog with the extension. Most of them are moving files from chromeos folder to chrome/browser folder.

I separated changes for managing and better readability. We could also keep it as one patch.

jkim-julie avatar Aug 28 '18 12:08 jkim-julie

let's merge it if you don't mind.

msisov avatar Oct 18 '18 07:10 msisov

Hi, sorry for constantly bumping old PRs/issues (just being excited to see chrome on wayland being feature-complete), but this looks like it could be merged after a rebase?

ammen99 avatar Dec 14 '18 21:12 ammen99

Hi, sorry for constantly bumping old PRs/issues (just being excited to see chrome on wayland being feature-complete), but this looks like it could be merged after a rebase?

Hi, thanks for being interested in it. As you can see from the changed files, it changed a lot of files and build configurations. It could have many conflicts if we keep it and try to rebase based on it. (We rebase ozone-wayland-dev branch weekly.) So, we decided to leave it as a patch and bring it whenever we need it for products.

jkim-julie avatar Dec 17 '18 01:12 jkim-julie

@jkim-julie Thanks for the clarification. I only thought this would help with the file dialogue on ozone/wayland.

ammen99 avatar Dec 17 '18 14:12 ammen99