Monocraft icon indicating copy to clipboard operation
Monocraft copied to clipboard

Added Turkish letters

Open yagiz-dev opened this issue 3 years ago • 2 comments

Following #15, I've added Turkish-specific characters.

image

It's my first time using FontForge, please check if I've done something wrong before merging it. I also haven't updated the previews, I'd be glad if you can.

yagiz-dev avatar Sep 07 '22 15:09 yagiz-dev

image

yagiz-dev avatar Sep 07 '22 15:09 yagiz-dev

Oh, you've made some changes. Should I remake the PR? @IdreesInc

yagiz-dev avatar Sep 07 '22 16:09 yagiz-dev

If you could, that'd be greatly appreciated. Otherwise leave it and at some point I should be able to get to it in a separate PR

IdreesInc avatar Sep 11 '22 01:09 IdreesInc

@evrifaessa

Following #15, I've added Turkish-specific characters.

image

It's my first time using FontForge, please check if I've done something wrong before merging it. I also haven't updated the previews, I'd be glad if you can.

are "Ş" and "ş" letters' extensions identical to how is it in minecraft? or it's just because the editor doesn't show the entire letter? unknown-2

eminarican avatar Sep 13 '22 11:09 eminarican

@evrifaessa

Following #15, I've added Turkish-specific characters. image It's my first time using FontForge, please check if I've done something wrong before merging it. I also haven't updated the previews, I'd be glad if you can.

are "Ş" and "ş" letters' extensions identical to how is it in minecraft? or it's just because the editor doesn't show the entire letter? unknown-2

Minecraft's original font doesn't have Turkish characters. The preview in the editor doesn't show the full glyph.

yagiz-dev avatar Sep 13 '22 15:09 yagiz-dev

@evrifaessa nope it does have turkish characters you could check it from textures under fonts/accented.png, take a look https://github.com/InventivetalentDev/minecraft-assets/blob/1.19.2/assets/minecraft/textures/font/accented.png

eminarican avatar Sep 16 '22 16:09 eminarican

I sincerely appreciate the effort that went into this PR, but I am going to close it for now as we need to ensure that all new glyphs match their Minecraft counterparts. Feel free to make another PR in the future including the updated glyphs!

IdreesInc avatar Oct 05 '22 22:10 IdreesInc

that disrespect tho lol

Screenshot_1

koply avatar Nov 12 '22 15:11 koply