Celeste icon indicating copy to clipboard operation
Celeste copied to clipboard

Increase default falling star height, add config to adjust height of where a falling star spawns.

Open SpaceXCheeseWheel opened this issue 2 years ago • 7 comments

Fix for #8. Set the new default height to y=330 to compensate for increased terrain height in new versions of minecraft. Also, added a new config option "falling-stars-max-height" so this can be configured. Note that with the new height, the speed at which the stars fell was sluggish, so I increased the speed as well.

SpaceXCheeseWheel avatar Nov 18 '22 06:11 SpaceXCheeseWheel

i looked in the config.. Could it be that this config of Version 2.0 is not up to date? The Setting falling-stars-max-height is no part of the config.yml...

CloudeLecaw avatar Mar 27 '23 10:03 CloudeLecaw

falling-stars-max-height is a new configuration option I introduced, so its not in the plugin yet. Previously it was a hardcoded value.

SpaceXCheeseWheel avatar Mar 27 '23 14:03 SpaceXCheeseWheel

so i cant change it? :(

CloudeLecaw avatar Mar 27 '23 14:03 CloudeLecaw

You can wait for IdreesInc to merge this PR, though that will take time. Otherwise, you can compile the plugin from my repository.

SpaceXCheeseWheel avatar Mar 27 '23 14:03 SpaceXCheeseWheel

i compiled your the version form your Repo and added the value

The "maximum" y level where a falling star can spawn

falling-stars-max-height: 320 to the config.. It looks like it does not work... the stars still fall down from 256 :3

The items apear at the first block seen but the animation starts at 256

CloudeLecaw avatar Apr 12 '23 18:04 CloudeLecaw

I need to express my apologies, I completely forgot about this. Thank you for giving it a shot, though. You are probably very close, my best guess is that when you cloned my repository to your computer, you are working off of the wrong branch. My changes are on a branch called "fallingStarHeight", not the default "master."

Here's the file: Celeste-SpXCheeseWheel.zip As always, don't trust files from random people on the internet. If you want, I can still help you compile it yourself. Let me know.

SpaceXCheeseWheel avatar Apr 12 '23 19:04 SpaceXCheeseWheel

Your right i took the masters one D: Thank you for pointing this out <3 It works like a charm!

CloudeLecaw avatar Apr 12 '23 20:04 CloudeLecaw