like-on-github
like-on-github copied to clipboard
Feedback
Interesting idea! :)
I tried it out: https://github.com/sindresorhus/today-i-liked
Some feedback:
- I had to create the readme.md file for it to work. That intro guide didn't say that. The toolbar icon also didn't notify me with a badge that something went wrong. It should.
- The intro says I need to set the
repoaccess, but that seems to only be needed for private repo access. - The "generate token" link in the options page should link directly to creating a new token: https://github.com/settings/tokens/new
- The extension toolbar icon is a bit too big and blurry on HighDPI screens:

- As you can see in https://github.com/sindresorhus/today-i-liked/tree/master, it didn't really work that well. It added it inside the blockquote I created and the date is
00. - Use full month name,
AugustnotAug.
@sindresorhus thank you for such a detailed feedback. I will look into it tonight. :)
Thanks for writing the extension!
The extension doesn't really need access to private repo. As you can see here. Many users will turn away if they assume that this extension needs access to all (incl. private repos). I definitely wouldn't have used this if it were the case.
One more thing: ###August 07, 2016 => ### August 7, 2016 (note both spacing and 07 => 7)
It also corrupted the previous entry when I added a new one: https://github.com/sindresorhus/likes/commit/b60386b7ca8dc00878c689d768fcd225a8caae4d (see the changes on line 6)
@sindresorhus except the icon. Rest of the stuff has been fixed. Thanks for the follow up.
@btbytes I updated the readme. You just need to give access to public repositories.
Another thing: It would be more natural for reading if dates were sorted descending (newest first). That way people can quickly see my latest likes without having to scroll to the bottom.