IdentityServer4 icon indicating copy to clipboard operation
IdentityServer4 copied to clipboard

Token validation options

Open pecanw opened this issue 5 years ago • 7 comments

What issue does this PR address? #4965 - Multiple valid issuers

Does this PR introduce a breaking change? NO

pecanw avatar Oct 12 '20 12:10 pecanw

CLA assistant check
All CLA requirements met.

dnfadmin avatar Oct 12 '20 12:10 dnfadmin

Thanks for your contribution!

IdentityServer4 is feature complete.

All new feature work will happen in our new organization. The new Duende IdentityServer is available under both a FOSS (RPL) and a commercial license. Development and testing is always free. Contact us for more information.

This repo will be maintained with bug fixes and security updates until November 2022.

leastprivilege avatar Oct 13 '20 03:10 leastprivilege

That being said, you can implement this feature yourself using our standard extensibility - so you have a workaround.

leastprivilege avatar Oct 13 '20 04:10 leastprivilege

Can you advise me how to extend it? The TokenValidator is internal and there's no option to change the TokenValidationParameters:

            var parameters = new TokenValidationParameters
            {
                ValidIssuer = _context.HttpContext.GetIdentityServerIssuerUri(),
                IssuerSigningKeys = validationKeys.Select(k => k.Key),
                ValidateLifetime = validateLifetime
            };

The only option is to write completely custom implementation of the ITokenValidator which is in general not a good idea. Even an ugly "copy-paste-rewrite" approach is not applicable as e.g TokenValidationLog is internal.

pecanw avatar Oct 13 '20 08:10 pecanw

Hm - OK - then I am wrong. Need to discuss this.

leastprivilege avatar Oct 13 '20 12:10 leastprivilege

@leastprivilege Any updates on this? We're in the same situation as OP and would love to see this merged.

redoz avatar May 07 '21 12:05 redoz

I am sorry, but we are not making feature updates anymore to v4.

Feel free to do a feature request in our new repo, we are happy to discuss this.

https://github.com/DuendeSoftware/IdentityServer

leastprivilege avatar May 07 '21 16:05 leastprivilege