IdentityServer4.WsFederation icon indicating copy to clipboard operation
IdentityServer4.WsFederation copied to clipboard

Incorrect parameter used when performing home realm selection

Open TheJayMann opened this issue 5 years ago • 0 comments

An issue which has caused me many problems, which I have recently solved, is that, on the netstandard2.0 branch, the wrong parameter is used when the relying party chooses the home realm.

https://github.com/IdentityServer/IdentityServer4.WsFederation/blob/b20a6f96394901c5964fedabb2af603515ef4fbd/src/IdentityServer4.WsFederation/WsFederationReturnUrlParser.cs#L66

The parameter being assigned to the IdP property is the wtrealm parameter, when it should be the Whr parameter. This is correct in the master branch, where it uses the HomeRealm property.

TheJayMann avatar Feb 20 '20 15:02 TheJayMann