pysaml2 icon indicating copy to clipboard operation
pysaml2 copied to clipboard

Incorrect domain validation

Open StuBz211 opened this issue 1 year ago • 1 comments

Incorrect domain validation since 2013 https://github.com/IdentityPython/pysaml2/commit/68ab79f49d752bd4905457f61d9a8e033141a403 (spaces between 1 in regular expression- it's a first problem)

Code Version

7.5.0

Expected Behavior

Domain's validating success

Current Behavior

regexp doesn't work

Possible Solution

To update validation domain regexp

Steps to Reproduce

from saml2.validate import valid_domain_name

valid_domain_name('simple.domain.com')

and getting an error ValueError("Not a proper domain name")

StuBz211 avatar Feb 07 '24 18:02 StuBz211

Fix is coming folks! https://github.com/IdentityPython/pysaml2/pull/951

StuBz211 avatar Feb 07 '24 18:02 StuBz211