pysaml2 icon indicating copy to clipboard operation
pysaml2 copied to clipboard

Duplicate code for ECP request

Open erakli opened this issue 6 years ago • 1 comments

There's same code pieces (with minor differences):

https://github.com/erakli/pysaml2/blob/master/src/saml2/client_base.py#L783 https://github.com/erakli/pysaml2/blob/master/src/saml2/ecp.py#L43

I think, we need to eliminate duplication and merge all ECP stuff in one place.

erakli avatar Nov 20 '18 10:11 erakli

I think you're right and probably the ECP support is taking a back seat in this project. Please do a PR for this if you can, AFAIK it seems to be trivial starting from what you show us

peppelinux avatar Sep 06 '20 00:09 peppelinux