pyjwkest icon indicating copy to clipboard operation
pyjwkest copied to clipboard

Added missing length bytes for AlgorithmID to otherInfo.

Open ghost opened this issue 6 years ago • 1 comments

Hello IdentityPython-team,

the key derivation for the Elliptic Curve Diffie-Hellman algorithms is not correctly working as intended in the RFC7518 (JWA) chapter 4.6.2. In reference to the National Institute of Standards and Technology publication NIST.SP.800-56Ar2 chapter 5.8.1.2.1., the "OtherInfo" parameter, used in the concat key derivation algorithm, should consist of bytes containing the length for each information to be assembled to the byte array. This length bytes are missing for the "AlgorithmID" information in the "extra.py" file. Please consider this request to fix the key derivation, as otherwise JWEs using Elliptic Curves cannot be processed.

Thanks and best regards,

Vincent Unsel

ghost avatar Sep 04 '19 15:09 ghost

I will definitely consider this. Just have to figure out why a couple of tests break with your changes.

rohe avatar Sep 04 '19 17:09 rohe