oidc-op icon indicating copy to clipboard operation
oidc-op copied to clipboard

claims_interface not seems to be a valid configuration parameter

Open melanger opened this issue 3 years ago • 4 comments

https://github.com/IdentityPython/oidc-op/blob/684355981ea12516e1b5ef3ed72a4ecf572109bf/src/oidcop/configure.py#L250

I have no claims_interface in my configuration but the logs say:

claims_interface not seems to be a valid configuration parameter

I guess it is an internal variable which should be skipped from logging.

melanger avatar Nov 03 '21 10:11 melanger

here https://github.com/IdentityPython/oidc-op/blob/684355981ea12516e1b5ef3ed72a4ecf572109bf/src/oidcop/configure.py#L203

We have to check if it's a deprecated parameter or not @rohe

peppelinux avatar Nov 03 '21 12:11 peppelinux

It might be that @nsklikas's changes to the claim interface made it superfluous.

rohe avatar Nov 03 '21 13:11 rohe

I made this clean up and also added this warning message to help end users to deal with breaking changes and deprecated parameters

https://github.com/IdentityPython/oidc-op/commit/0123d25953e8b7f45932bd5e6945b518d66a3b04#diff-6c1cca6748acc9f2583d0fca54d4bbbfc92e8836711cf318ca09d3cd4e60f00dR247

So, I'd keep this issue until we'll find this parameter and decide if it's needed or not. @melanger feel free to go ahead with string search filters in your IDE to found the truth!

I'll follow you in this PR

peppelinux avatar Nov 03 '21 13:11 peppelinux

@nsklikas any thoughts?

peppelinux avatar Nov 03 '21 13:11 peppelinux