SATOSA icon indicating copy to clipboard operation
SATOSA copied to clipboard

signed AuthnRequest from entity not in metadata flagged as IncorrectlySigned

Open rhoerbe opened this issue 5 years ago • 1 comments

misleading exception if condition mentioned in title occurs

Code Version

4.4.0

Expected Behavior

exception should name the correct cause

Possible Solution

(1) rename exception to "unkown Entity or invalid request signature", or (better) (2) validate entityid against metadata before validating signature

Steps to Reproduce

  • remove the message obfuscation with rerasing exceptions as SATOSAUnknownError in base.run()
  • issue request from unregistered entity

rhoerbe avatar Jul 12 '19 18:07 rhoerbe

Also related to https://github.com/IdentityPython/SATOSA/issues/227

peppelinux avatar Aug 11 '19 11:08 peppelinux