SATOSA icon indicating copy to clipboard operation
SATOSA copied to clipboard

Full symmetric meshed metadata proxy

Open mrvanes opened this issue 7 years ago • 6 comments

This pullrequest makes satosa a full symmetric meshed federation hub-n-spoke saml proxy. That means that SP's can connect with mirrored IdP's and IdP's can connect with mirrored SP entityID. Meanwhile, satosa can still inject attributes or block access where or when necessary.

mrvanes avatar Nov 20 '17 15:11 mrvanes

The tests now pass the PR.

mrvanes avatar Nov 23 '17 09:11 mrvanes

I actually thought we had this in a microservice already

leifj avatar Nov 23 '17 09:11 leifj

I've looked, but couldn't find one that covers our requirements, which one do you mean?

mrvanes avatar Nov 23 '17 15:11 mrvanes

I've been looking at the change and could see a way to refactor get_metadata_desc() for both Front- and Backend saml2 modules. This would however require generificication of the specific sp_/idp_entities variable naming and passing a value to discern between idpsso and spsso(_descriptor). We would win brevity of the code, but completely loose readability (in my opinion) of the function. Is that really what we want?

mrvanes avatar Feb 12 '18 08:02 mrvanes

It would be helpful if this PR was updated with the information requested in the shiny new PR template added to this project. The PR as it stands now does not have a sufficient description around how this works or why it’s built this way.

hlflanagan avatar Feb 21 '18 19:02 hlflanagan

New tests were added Old code mistakes have been corrected Existing tests were modified to cater for earlier mistakes in old code Changes have been rebased on upstream master Purpose of PR is creating a hub-n-spoke proxy that mimics full-meshed federation by adding the opposite of SAMLMirrorFrontend, we have extensively discussed this at TIIME This may not be the best way to implement this, see the PR as a base to start discussing this functionality

mrvanes avatar Feb 23 '18 08:02 mrvanes